Fix PDF report section chips not scrolling in Apple Preview - #13225
Open
benbowler wants to merge 6 commits into
Open
Fix PDF report section chips not scrolling in Apple Preview#13225benbowler wants to merge 6 commits into
benbowler wants to merge 6 commits into
Conversation
🎭 Playwright reports for efc736c: 📚 Storybook for efc736c: 📦 Build files for efc736c:
|
benbowler
marked this pull request as draft
July 30, 2026 10:37
benbowler
changed the title
Apple Preview ignores a named destination's top coordinate when the left one is unset, so the report's header chips scroll nowhere. The patch writes `node.box.left ?? 0`, the expression react-pdf pull request 3460 uses, so it can go once a release holds that fix.
The report case reads the downloaded report and asserts that every section anchor holds a left coordinate. Dropping the patch now fails the suite instead of passing without notice.
PDF_PAGE_BOTTOM_PADDING held a raw 60 points, which rendered about twice the space the design leaves under the footer links. It now scales the design's 44, and a Jest case pins that value.
shervElmi
force-pushed
the
bug/13212-pdf-report-section-links-apple-preview
branch
from
August 9, 2026 22:46
531babf to
35dd296
Compare
shervElmi
changed the title
shervElmi
changed the title
…rt-section-links-apple-preview.
shervElmi
marked this pull request as ready for review
August 9, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s):
Relevant technical choices
patches/@react-pdf+render+4.5.1.patchnode.box.left ?? 0insetDestination, the expression react-pdf pull request 3460 uses.assets/js/components/pdf-export/pdf-theme.tsPDF_PAGE_BOTTOM_PADDINGfrom the design's 44 instead of the raw 60 points.tests/playwright/specs/pdf-generation/pdf-generation-page.tsreadPDFReport(), which reads the report withlatin1, one character per byte.tests/playwright/specs/pdf-generation/pdf-generation.spec.ts(section-mainDashboardTraffic), and that no anchor reads/XYZ null.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist